D'Arcy from Winnipeg
Solution Architecture, Business & Entrepreneurship, Microsoft, and Adoption

Importance of Architecture and Code Review

Saturday, December 17, 2005 4:21 AM

One thing we're trying to do more at work is regular architecture and code reviews at every stage of a project. I worked on a project recently where we didn't do that, and we ran into huge issues; mainly in the are of communication and expectation.

The important thing with a review is that you don't just get one other person to review it; you need a team. We get all our guys (or as many as can make it) together at the office and review the architecture of the application and also request coding reviews throughout development. Even though you might not be on a project, if its being done by your company then you still have a stake in it. The same attitude needs to be taken by the person who's being reviewed. When I was approached to have a code review done on myself, I was super defensive: so everyone is just going to nit-pick my code from a project that I didn't feel was my best work?! But everyone has been great to reassure me that its not about the developer, its about the code and ultimately about all of us becoming better developers because of it.

So the next time you have a project, get some input from the other dev's for your architecture, and ask others to take a look at your code. Sometimes its not even about whether your code is “good”, but ways you can improve or optimize it, which isn't a negative thing at all.

D




Feedback

# re: Importance of Architecture and Code Review

Hey D. I know exactly what you mean about getting defensive. It takes a lot to break down that barrier. Of course, it helps when you work with a cool bunch of guys who approach a review the way you said, and that is with the intent to improve the code, not pick apart your work. I'll keep that in mind the next time I'm reviewing (getting reviewed).

-Shaneo 12/20/2005 5:48 AM | Shaneo

Post a comment